Unbreak setting of entrypoint in exec form when property mode is enabled #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
============================================
+ Coverage 51.78% 51.82% +0.04%
- Complexity 1369 1372 +3
============================================
Files 147 147
Lines 7479 7477 -2
Branches 1135 1134 -1
============================================
+ Hits 3873 3875 +2
+ Misses 3241 3237 -4
Partials 365 365
|
|
There are currently conflicts because of another merge for health check. |
Any <entrypoint><exec><arg>...</arg> would disapsear due to bad string conversion. Fix is to get rid of all string conversions dealing with Arguments (which was mostly from test).
stromnet
force-pushed
the
unbreak-arguments-override
branch
from
0d90e9f to
a9da3b6
Compare
|
Rebased on master, ready for merge. I'd rather merge this one before putting effort into changing into Java8, as this bug was a blocker for one of our projects. But yes, that's yet another use-case where lambdas would be nice :) |
rhuss
approved these changes
May 16, 2018
rhuss
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any
<entrypoint><exec><arg>...</arg>would disappear when any property mode was enabled (but corresponding property not defined as property), due to bad string conversion.Fix is to get rid of all string conversions dealing with Arguments (which was mostly from test).
Bug in #948